Add fallback to root prefix #3435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hind-M
force-pushed
the
default_root
branch
2 times, most recently
from
d61323f to
99a43da
Compare
Hind-M
commented
Sep 9, 2024
| @@ -27,6 +27,7 @@ namespace mamba | |||
| bool remove_all = flags & MAMBA_REMOVE_ALL; | |||
|
|
|||
| config.at("use_target_prefix_fallback").set_value(true); | |||
| config.at("use_root_prefix_fallback").set_value(false); | |||
There was a problem hiding this comment.
I set the flag to false here since it's related to environment removal and could be dangerous (so no fallback in this case).
Hind-M
force-pushed
the
default_root
branch
from
5f32218 to
da1ea7d
Compare
|
Wow, all green! 😄 |
SylvainCorlay
approved these changes
Sep 10, 2024
JohanMabille
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix part of #3426 (second point).