Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mamba content trust] Enable verifying packages signatures #3192

Merged
merged 10 commits into from
Mar 8, 2024

Conversation

Hind-M
Copy link
Member

@Hind-M Hind-M commented Feb 19, 2024

Based on initial work in #3050
Making this ready for review and resuming work on another PR (tests and additional tweaks) to avoid frequent rebasing.

@Hind-M Hind-M added the release::enhancements For enhancements PRs or implementing features label Feb 20, 2024
@Hind-M Hind-M marked this pull request as ready for review March 1, 2024 16:30
@Hind-M Hind-M requested a review from AntoinePrv March 1, 2024 16:32
libmamba/src/solver/libsolv/helpers.cpp Outdated Show resolved Hide resolved
libmamba/src/solver/libsolv/helpers.cpp Outdated Show resolved Hide resolved
libmamba/src/solver/libsolv/helpers.cpp Outdated Show resolved Hide resolved
libmamba/src/solver/libsolv/helpers.cpp Outdated Show resolved Hide resolved
libmamba/include/mamba/solver/libsolv/database.hpp Outdated Show resolved Hide resolved
@AntoinePrv
Copy link
Member

Could we also add a test related to signature loading in test_database.cpp? There is a small test repodata being used under libmamba/tests/data/repodata/conda-forge-numpy-linux-64.json, that could modified, or another sample could be created for that purpose.

@Hind-M Hind-M force-pushed the tuf branch 2 times, most recently from deaeb60 to 6db5704 Compare March 7, 2024 09:21
@Hind-M Hind-M merged commit ce840bb into mamba-org:main Mar 8, 2024
28 checks passed
@SylvainCorlay
Copy link
Member

Congrats on landing this @Hind-M

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release::enhancements For enhancements PRs or implementing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants