Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding locks for cache directories in case multiple processes are try…. #2811

Merged
merged 2 commits into from
Sep 13, 2023

Conversation

rmittal87
Copy link
Contributor

fixes 2666

Change-Id: Ib71f328f345569868602de32945f56d6f65096fd

…ing to create an environment at the same time

Change-Id: Ib71f328f345569868602de32945f56d6f65096fd
@rmittal87
Copy link
Contributor Author

fixes #2666

@rmittal87 rmittal87 changed the title Adding locks for cache directories in case multiple processes are try… Adding locks for cache directories in case multiple processes are try…. fixes #2666 Sep 6, 2023
@rmittal87 rmittal87 changed the title Adding locks for cache directories in case multiple processes are try…. fixes #2666 Adding locks for cache directories in case multiple processes are try…. Sep 6, 2023
@jonashaag
Copy link
Contributor

Cool! Again, is there a way to test this? I know race conditions are hard to test, but maybe we can build something that spawns a few concurrent workers for a couple of times and if no crash is observed, it is accepted.

@rmittal87 rmittal87 force-pushed the multiprocessing branch 3 times, most recently from f484eb7 to d781446 Compare September 13, 2023 06:39
@JohanMabille
Copy link
Member

JohanMabille commented Sep 13, 2023

Thanks!

Can you run the linter to fix the CI? pre-commit run --all-files should do it.

Change-Id: Ie793d88098f20dc622f398334a77f63cacfe982d
@JohanMabille JohanMabille merged commit a5c5198 into mamba-org:main Sep 13, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants