Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All headers at the top #2658

Merged
merged 1 commit into from
Jul 19, 2023
Merged

All headers at the top #2658

merged 1 commit into from
Jul 19, 2023

Conversation

AntoinePrv
Copy link
Member

No description provided.

@AntoinePrv AntoinePrv requested a review from JohanMabille July 6, 2023 14:26
@AntoinePrv AntoinePrv self-assigned this Jul 18, 2023
Klaim
Klaim approved these changes Jul 18, 2023
View reviewed changes
Copy link
Member

@Klaim Klaim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

By the way, I thought the includes sorting for clang-format would also move them at the top automatically? Or is that an option we dont use?

@AntoinePrv
Copy link
Member Author

Sorting still happens among headers that are next to each others. In fact you can use comments to make separation, which is convenient when some incomplete headers need to be included last.

@AntoinePrv
Copy link
Member Author

Merging since the failure is unrelated.

@AntoinePrv AntoinePrv merged commit 6c6d7db into mamba-org:main Jul 19, 2023
@AntoinePrv AntoinePrv deleted the fix-headers branch July 19, 2023 08:37
cvanelteren pushed a commit to cvanelteren/mamba that referenced this pull request Jul 31, 2023
@AntoinePrv @cvanelteren
All headers at the top (mamba-org#2658)
c4fbb2a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohanMabille JohanMabille JohanMabille approved these changes

@Klaim Klaim Klaim approved these changes

Assignees

@AntoinePrv AntoinePrv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AntoinePrv @Klaim @JohanMabille