Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove prefixdata from solver interface #1550

Merged
merged 2 commits into from
Mar 21, 2022
Merged

remove prefixdata from solver interface #1550

merged 2 commits into from
Mar 21, 2022

Conversation

wolfv
Copy link
Member

@wolfv wolfv commented Mar 2, 2022 •
edited
Loading

  • check if we need to add the real_solvable_url thing for mamba to make force-reinstall work there, too.

JohanMabille
JohanMabille reviewed Mar 2, 2022
View reviewed changes
Copy link
Member

@JohanMabille JohanMabille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

libmamba/src/core/package_info.cpp Show resolved Hide resolved
@wolfv
Copy link
Member Author

wolfv commented Mar 2, 2022

OK, so we need to find a way to merge this info with the differently loaded install data in mamba.

@wolfv wolfv force-pushed the solver_prefix_data branch from 0c46fef to a1e382a Compare March 3, 2022 14:45
@wolfv
Copy link
Member Author

wolfv commented Mar 3, 2022 •
edited
Loading

  • need to use the same function inside mamba_env.py or factor it out

@wolfv wolfv force-pushed the solver_prefix_data branch from 4a849e9 to a0f81d5 Compare March 4, 2022 09:19
@wolfv wolfv force-pushed the solver_prefix_data branch from a0f81d5 to 20fdfd7 Compare March 10, 2022 16:29
@wolfv wolfv merged commit d232bcb into mamba-org:master Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohanMabille JohanMabille JohanMabille left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wolfv @JohanMabille