Micromamba: Substitute env vars in .condarc #1423
Conversation
|
@wolfv this should be ready to go with one minor todo where my C++ skills weren't good enough. How do you make a function that can return a |
|
@jonashaag there are two options -- either to use |
|
@jonashaag can you have a look to see if this is what you had in mind? Now when the env var exists, but is empty, it will add an empty string ( |
|
@wolfv I was about to push my changes at this very moment :D |
|
Nooooooooo! Sorry :/ |
|
https://github.com/jonashaag/mamba/tree/envsubst2-2 Can you review this instead? |
|
But I'm happy to see that you made essentially the same changes :) Are you ok with the change in behaviour that empty env vars are now not considered absent anymore? (You also seem to have made that decision in your changes) |
|
I am happy with your version, too. Do you want to force push to this branch to erase my changes and use yours? Sorry again, I should've coordinated :) |
|
No worries. Force pushed. |
|
@wolfv I don't understand the remaining Windows test failure. It seems that Micromamba thinks that |
|
I think So IMHO we can skip that test on Windows.
|
|
Oh wow, well that's unfortunate but then we can simplify some of the code and skip that test. |
| @@ -14,19 +16,21 @@ def config(*args): | |||
| cmd = [umamba, "config"] + [arg for arg in args if arg] | |||
| res = subprocess.check_output(cmd) | |||
| if "--json" in args: | |||
| j = json.loads(res) | |||
| j = yaml.load(res, yaml.FullLoader) | |||
There was a problem hiding this comment.
I think you've filed a bug for this already, right?
|
Thanks for tackling this! |
The empty string is found at the start of the string, pos = 0, and replaced over and over again. If the replacement string is also empty, the size of the data string will not change. If the replacement string is not empty, it will be repeatedly prepended to the data string. While most callers are careful to ensure the search string is not empty, PosixActivator::update_prompt() lost this property in "Micromamba: Substitute env vars in .condarc (mamba-org#1423)" (9e5f8fd). Rather than restore the check in the caller, fix the root of the issue in replace_all() itself. I ran into this bug as a Micromamba user in a particular set of circumstances where the CONDA_PROMPT_MODIFIER env var was the empty string.¹ It manifested to me the user as a `micromamba create` invocation hanging at the linking phase for any package with a post-link script (such as openmpi). The generated post-link script wrapper invoked, indirectly, `micromamba shell --shell bash activate <path>` which was hanging during update_prompt(). ¹ nextstrain/cli#223 (comment)
New version of #1416 with only
${var}support (and$$support)