Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix realpath and tac missing on OSX #17

Merged

Conversation

davidxbors
Copy link
Contributor

@davidxbors davidxbors commented Nov 18, 2021

As @Sergiu121 pointed out in issue #1 tac is named gtac on macOS systems when installed with the coreutils package using MacPorts. The same problem exists with realpath. A simple solution is to install the coreutils package using brew instead.

@razvand razvand self-requested a review March 23, 2022 07:10
@razvand razvand self-assigned this Mar 23, 2022
Copy link
Member

@razvand razvand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the commit message. The commit line looks good. But you need a more detailed description about what the commit does. Mention the requirement for the coreutils package to include the realpath and the tac executable files.

README.md Outdated Show resolved Hide resolved
@razvand razvand self-requested a review April 6, 2022 09:03
As @Sergiu121 pointed out in issue malus-security#1 `tac` is named `gtac`
on macOS systems when installed with the `coreutils` package
using `MacPorts`. The same problem exists with `realpath`.
A simple solution is to install the coreutils package using
`brew` instead.
@davidxbors davidxbors force-pushed the fix-realpath-and-tac-not-found-osx branch from fab0a2d to d3c69f9 Compare April 6, 2022 17:25
Make brew the default package manager in the README install instructions
for Darwin systems.
Copy link
Member

@razvand razvand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good. Thanks, @davidxbors

@razvand razvand merged commit d9d8b5a into malus-security:master Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants