Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ctx.data arguments type with output parser #21

Merged
merged 1 commit into from
Jul 28, 2023
Merged

fix: ctx.data arguments type with output parser #21

merged 1 commit into from
Jul 28, 2023

Conversation

swallowtail62
Copy link
Contributor

@swallowtail62 swallowtail62 commented Jul 10, 2023 •
edited
Loading

Close #22

🎯 Changes

Currently, when using the output parser, the argument type of ctx.data is undefined. So, I modified it to take output parser into account.

Please review when you have time.

✅ Checklist

  • If necessary, I have added documentation related to the changes made.
  • I have added or updated the tests related to the changes made.

@kristiandupont
Copy link

I would love to see this merged, is there anything blocking it?

@boredland
Copy link

We're super interested in this too! Can't wait to get typesafe mocks!

@maloguertin maloguertin merged commit 45e9d41 into maloguertin:main Jul 28, 2023
@swallowtail62 swallowtail62 deleted the fix/ctx-data-arg-type branch July 29, 2023 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maloguertin maloguertin maloguertin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When output parser is used in the procedure, ctx.data argument type is unknown (invalid type)
4 participants
@swallowtail62 @kristiandupont @boredland @maloguertin