Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enables workflow dispatch for clang and scan_builds. #312

Merged
merged 2 commits into from
Nov 6, 2023

Conversation

francocipollone
Copy link
Collaborator

🎉 New feature

Closes #

Summary

what the title says

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if it affects the public API)

@francocipollone francocipollone added do-clang-test Triggers clang builds in a pull request do-static-analyzer-test labels Sep 28, 2023
@francocipollone francocipollone added do-clang-test Triggers clang builds in a pull request do-static-analyzer-test and removed do-clang-test Triggers clang builds in a pull request do-static-analyzer-test labels Oct 3, 2023
@francocipollone
Copy link
Collaborator Author

Ci failing due to maliput/maliput_object_py#10

@francocipollone francocipollone added do-clang-test Triggers clang builds in a pull request do-static-analyzer-test and removed do-clang-test Triggers clang builds in a pull request do-static-analyzer-test labels Oct 4, 2023
@francocipollone
Copy link
Collaborator Author

Now clang CI failing in testing:

- maliput.RouteLaneSRelationTest EvaluateComputeLaneSRangeRelationSameLaneSRanges
  <<< failure message
    /__w/maliput_infrastructure/maliput_infrastructure/maliput_ws/src/maliput/test/routing/route_test.cc:691
    Expected equality of these values:
      LaneSRangeRelation::kSucceedingLeft
        Which is: kSucceedingLeft
      dut.ComputeLaneSRangeRelation(kLaneSRangeD, kLaneSRangeE)
        Which is: kSucceedingRight
    /__w/maliput_infrastructure/maliput_infrastructure/maliput_ws/src/maliput/test/routing/route_test.cc:693
    Expected equality of these values:
      LaneSRangeRelation::kSucceedingLeft
        Which is: kSucceedingLeft
      dut.ComputeLaneSRangeRelation(kLaneSRangeD, kLaneSRangeF)
        Which is: kSucceedingRight
    /__w/maliput_infrastructure/maliput_infrastructure/maliput_ws/src/maliput/test/routing/route_test.cc:716
    Expected equality of these values:
      LaneSRangeRelation::kPreceedingLeft
        Which is: kPreceedingLeft
      dut.ComputeLaneSRangeRelation(kLaneSRangeI, kLaneSRangeE)
        Which is: kPreceedingRight
  >>>

let's see how maliput/maliput#596 goes

@agalbachicar agalbachicar mentioned this pull request Nov 1, 2023
5 tasks
@francocipollone francocipollone added do-clang-test Triggers clang builds in a pull request do-static-analyzer-test and removed do-clang-test Triggers clang builds in a pull request do-static-analyzer-test labels Nov 1, 2023
@francocipollone
Copy link
Collaborator Author

✔️ scan build CI is passing

❎ Failing clang CI

It seems that delphyne_demos tests are failing due to "RuntimeError: Registering frame with an id that has already been registered: 1"
🙃

    Traceback (most recent call last):
      File "/__w/maliput_infrastructure/maliput_infrastructure/maliput_ws/install/delphyne_demos/bin/delphyne_mali", line 36, in <module>
        delphyne_demos.demos.mali.main()
      File "/__w/maliput_infrastructure/maliput_infrastructure/maliput_ws/install/delphyne_demos/lib/python3.8/site-packages/delphyne_demos/demos/mali.py", line 398, in main
        simulation_tree.setup(
      File "/__w/maliput_infrastructure/maliput_infrastructure/maliput_ws/install/delphyne/lib/python3.8/site-packages/delphyne/trees.py", line 66, in setup
        super().setup(builder=builder, **kwargs)
      File "/opt/ros/foxy/lib/python3.8/site-packages/py_trees/trees.py", line 324, in setup
        setup(
      File "/opt/ros/foxy/lib/python3.8/site-packages/py_trees/trees.py", line 106, in setup
        visited_setup()
      File "/opt/ros/foxy/lib/python3.8/site-packages/py_trees/trees.py", line 97, in visited_setup
        node.setup(**kwargs)
      File "/__w/maliput_infrastructure/maliput_infrastructure/maliput_ws/install/delphyne/lib/python3.8/site-packages/delphyne/behaviours/agents.py", line 153, in setup
        builder.add_agent(
    RuntimeError: Registering frame with an id that has already been registered: 1

@francocipollone
Copy link
Collaborator Author

@francocipollone francocipollone added do-clang-test Triggers clang builds in a pull request do-static-analyzer-test and removed do-clang-test Triggers clang builds in a pull request do-static-analyzer-test labels Nov 3, 2023
@francocipollone
Copy link
Collaborator Author

CI is passing due to maliput/delphyne#861 shares same branch name

@francocipollone francocipollone merged commit 76d27aa into main Nov 6, 2023
20 of 34 checks passed
@francocipollone francocipollone deleted the francocipollone/enable_workflowd_dispatch branch November 6, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-clang-test Triggers clang builds in a pull request do-static-analyzer-test
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant