Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Authorization not asked in case of .significant subscription #254

Closed
jeden opened this issue Apr 26, 2019 · 3 comments
Closed

Authorization not asked in case of .significant subscription #254

jeden opened this issue Apr 26, 2019 · 3 comments
Labels
bug
Milestone
4.0.1

Comments

@jeden
Copy link

jeden commented Apr 26, 2019

If I call locateFromGPS() with .significant subscription, it doesn't ask for authorization, whereas in the case of .continous and .oneShot it does.

It looks like a bug, I can fix it myself, but before trying, I'd like to know if that's the intended behavior.
@malcommac
Copy link
Owner

I think it’s actually a bug. You can make a PR, I’ll review it next Tue when I’ll back to office. Thanks!

malcommac added a commit that referenced this issue Apr 30, 2019
@malcommac
#254 Fixed an issue with significant auth
5e0fbbf
@malcommac
Copy link
Owner

Fixed in 4.0.1

@malcommac malcommac added this to the 4.0 milestone Apr 30, 2019
@malcommac malcommac added the bug label Apr 30, 2019
@jeden
Copy link
Author

jeden commented May 5, 2019 via email

@malcommac malcommac modified the milestones: 4.0.0, 4.0.1 May 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
4.0.1
Development

No branches or pull requests
2 participants
@malcommac @jeden