Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove component dictionaries #163

Closed
Hout opened this issue Feb 21, 2016 · 2 comments
Closed

Remove component dictionaries #163

Hout opened this issue Feb 21, 2016 · 2 comments
Milestone

Comments

@Hout
Copy link
Contributor

Hout commented Feb 21, 2016

Creation from component dictionaries seems superfluous. Dates can be created with optional parameters alike a date component dictionary:

let date1 = NSDate(year: 2016, month: 2, day: 21)
let date2 = NSDate(dateComponentDictionary: [year: 2016, month: 2, day: 21)])

The latter seems equally functional but with more clutter...
Unless this has a broader rationale than flexibility in creation of dates, I propose to get rid of this construction.

@malcommac
Copy link
Owner

I agree, we could mark it as deprecated

@Hout
Copy link
Contributor Author

Hout commented Feb 24, 2016

That will be for 3.0.5 then.

@Hout Hout added this to the v3.0.5 milestone Feb 24, 2016
@Hout Hout closed this as completed Feb 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants