Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TableAdapter Element Nullability #18

Closed
wow-such-amazing opened this issue May 27, 2019 · 1 comment
Closed

TableAdapter Element Nullability #18

wow-such-amazing opened this issue May 27, 2019 · 1 comment
Assignees
Labels
bug Something isn't working
Milestone

Comments

@wow-such-amazing
Copy link
Contributor

Hi again!)

I didn't have time to go deep. But I found that element in CollectionAdapter events is non-optional while in TableAdapter events it is optional. And that increases the difficulty to switch from FlowKitManager plus it forces to add guards and if statements. Or for example if CellModel contains the height of the cell developer have to create some default value.

What is the reason behind the idea that TableAdapter events contains optional element?

Thank you a lot for keep improving this library!

@malcommac
Copy link
Owner

it's related to the cachedContext which save data for didEndDisplay and I'm missing it from the CollectionAdapter's Event counterpart. Anyway it should be not necessary anymore so I've removed the nullability from the TableAdapter's Event.

@malcommac malcommac self-assigned this Sep 15, 2019
@malcommac malcommac added the bug Something isn't working label Sep 15, 2019
@malcommac malcommac added this to the 1.1.0 milestone Sep 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants