Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Karaf configs aligned with official AET release #5

Conversation

jwadolowski
Copy link
Contributor

I compared https://github.com/Cognifide/aet/releases/download/3.1.0/configs.zip with the content of karaf/configs directory and fixed differences between them.

@Skejven official release contains com.cognifide.aet.vs.mongodb.MongoDBClient.cfg and org.ops4j.pax.logging.cfg as well. In the first case I assume we rely on MONGODB_URI to set the right MongoDB endpoint, the second config is all about loggers, which are not important in case Docker deployment (Karaf logs to stdout, which can be picked up easily with docker logs -f <container_id>. Is my understanding correct?

Copy link
Owner

@malaskowski malaskowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jwadolowski there is separate directory karaf/config instead of original content of config.zip because Docker environment differs from the default Vagrant configuration, e.g.:

  • it runs 6 chrome instances, so there should be 6 collectors - therefore the CollectorMessageListenerImpl-F.cfg is configured additionally as the 6th collector. In the future number of browsers and collectors should be managed better by AET than now (please see Unify configuring AET testing throughput wttech/aet#361 for that).
    See also my comments for other values changes.

Your understanding of monogDB and logger configuration is correct.

@@ -18,6 +18,6 @@

ft=120
mttl=300
urlPackageSize=1
maxMessagesInCollectorQueue=10
urlPackageSize=5
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This number should be modified to 1, thanks for spotting that. I raised wttech/aet#421 .

urlPackageSize=1
maxMessagesInCollectorQueue=10
urlPackageSize=5
maxMessagesInCollectorQueue=20
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should remain 6 - 10 here. It defines the maximum number of collection tasks waiting in the queue. It should be at least the number of collectors in the system (if it is less some of collectors will be never used) but not to big (as it will occur with timeouts on collection taks). See more in wttech/aet#361 about this value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants