Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and improve plotting pairwise average fst #579

Merged
merged 2 commits into from
Aug 9, 2024

Conversation

alimanfoo
Copy link
Member

@alimanfoo alimanfoo commented Aug 9, 2024

  • Resolves FST plotting function error #567.
  • Removes warnings associated with pandas chained assignments.
  • Dynamically sizes plot based on number of cohorts.
  • Adds a title to the plot.
  • Disable colouring by default if an annotation is requested in the upper triangle (as the table then contains a mix of two different types of values and the colouring becomes confusing).
  • Code simplification.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@alimanfoo
Copy link
Member Author

Applies the fix from #540 to resolve the error raised by @KellyLBennett in #567. Here's the fixed plot:

image

@alimanfoo alimanfoo requested review from leehart and ahernank August 9, 2024 15:56
@alimanfoo alimanfoo merged commit 3b1640b into master Aug 9, 2024
8 checks passed
@alimanfoo alimanfoo deleted the fst-bug-alimanfoo-2024-08-09 branch August 9, 2024 16:41
@alimanfoo
Copy link
Member Author

Thanks @leehart and @ahernank

@alimanfoo alimanfoo added the BMGF-068808 Work supported by BMGF grant INV-068808 (MalariaGEN 2024-2027). label Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BMGF-068808 Work supported by BMGF grant INV-068808 (MalariaGEN 2024-2027).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FST plotting function error
3 participants