Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update core-js to the latest version 🚀 #21

Closed
wants to merge 2 commits into from
Closed

Update core-js to the latest version 🚀 #21

wants to merge 2 commits into from

Conversation

greenkeeper[bot]
Copy link
Contributor

@greenkeeper greenkeeper bot commented Mar 19, 2019

The dependency core-js was updated from 2.6.5 to 3.0.0.

This version is not covered by your current version range.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.

Find out more about this release.

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper bot 🌴

@ComFreek
Copy link
Collaborator

Apparently, @angular/devkit imports something which has now been stripped from core-js (?)

The Travis log says:

ERROR in ./node_modules/@angular-devkit/build-angular/src/angular-cli-files/models/jit-polyfills.js

Module not found: Error: Can't resolve 'core-js/es7/reflect' in '/home/travis/build/makimenko/angular-template-for-threejs/node_modules/@angular-devkit/build-angular/src/angular-cli-files/models'

Hmm, does Greenkeeper work hand in hand with Angular Update?

@ComFreek ComFreek added the blocked-upstream Change/update blocked due to a dependency which requries the old version. label Mar 20, 2019
@makimenko
Copy link
Owner

Apparently, @angular/devkit imports something which has now been stripped from core-js (?)
Hmm, does Greenkeeper work hand in hand with Angular Update?

Yep, saw it. Let's don't merge it yet.

greenkeeper bot added a commit that referenced this pull request Apr 6, 2019
@greenkeeper
fix(package): update core-js to version 3.0.1
e894c22 
Closes #21
@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented Apr 6, 2019

  • The dependency core-js was updated from 2.6.5 to 3.0.1.

Update to this version instead 🚀

Release Notes for 3.0.1 - 2019.04.06
  • Fixed some cases of work with malformed URI sequences in URLSearchParams, #525
  • Added a workaround for a rollup issue, #513

greenkeeper bot added a commit that referenced this pull request May 19, 2019
@greenkeeper
fix(package): update core-js to version 3.1.0
ba403e7 
Closes #21
@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented May 19, 2019

  • The dependency core-js was updated from 2.6.6 to 3.1.0.

Update to this version instead 🚀

greenkeeper bot added a commit that referenced this pull request May 20, 2019
@greenkeeper
fix(package): update core-js to version 3.1.1
48070a6 
Closes #21
@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented May 20, 2019

  • The dependency core-js was updated from 2.6.7 to 3.1.1.

Update to this version instead 🚀

greenkeeper bot added a commit that referenced this pull request May 21, 2019
@greenkeeper
fix(package): update core-js to version 3.1.2
5ef0302 
Closes #21
@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented May 21, 2019

  • The dependency core-js was updated from 2.6.8 to 3.1.2.

Update to this version instead 🚀

@ComFreek
Copy link
Collaborator

Sadly still breaking 🤷‍♂

greenkeeper bot added a commit that referenced this pull request May 27, 2019
@greenkeeper
fix(package): update core-js to version 3.1.3
f880bf1 
Closes #21
@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented May 27, 2019

  • The dependency core-js was updated from 2.6.9 to 3.1.3.

Update to this version instead 🚀

greenkeeper bot added a commit that referenced this pull request Jun 15, 2019
@greenkeeper
fix(package): update core-js to version 3.1.4
b904aa4 
Closes #21
@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented Jun 15, 2019

  • The dependency core-js was updated from 2.6.9 to 3.1.4.

Update to this version instead 🚀

greenkeeper bot added a commit that referenced this pull request Aug 9, 2019
@greenkeeper
fix(package): update core-js to version 3.2.0
745c506 
Closes #21
@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented Aug 9, 2019

  • The dependency core-js was updated from 2.6.9 to 3.2.0.

Update to this version instead 🚀

greenkeeper bot added a commit that referenced this pull request Aug 12, 2019
@greenkeeper
fix(package): update core-js to version 3.2.1
81ba478 
Closes #21
@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented Aug 12, 2019

  • The dependency core-js was updated from 2.6.9 to 3.2.1.

Update to this version instead 🚀

@ComFreek
Copy link
Collaborator

ComFreek commented Aug 15, 2019 •
edited
Loading

I updated all deps via npm-check-updates. It'll be pushed in the next commit: 1ba3f27.

@ComFreek ComFreek closed this Aug 15, 2019
@ComFreek ComFreek deleted the greenkeeper/core-js-3.0.0 branch August 15, 2019 08:32
ComFreek added a commit that referenced this pull request Aug 15, 2019
@ComFreek
fix(test): polyfill removed core-js file
8550e1e 
Finally fixes #21 despite previous commit.
@ComFreek
Copy link
Collaborator

Sorry, the previous commit didn't fully fix it. But now it is thanks to zloirock/core-js#412 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
blocked-upstream Change/update blocked due to a dependency which requries the old version. greenkeeper
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ComFreek @makimenko