Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expanded summary sections to include sentence and component summaries. #8

Merged
merged 2 commits into from
Apr 17, 2020

Conversation

LongForWisdom
Copy link
Contributor

  • Changed General and Technical Template to include Sentence Summary, Paragraph Summary, Component Summary.
  • Removed Component List and old Summary heading from the General and Technical templates.
  • Changed all MIPs to follow the new templates.
  • Wrote sentence summaries for each MIP.
  • Paragraph Summaries for each MIP are a direct copy of the previous summaries.
  • Wrote component summaries for each component in each MIP.

Component list I removed because it has too much overlap with Component Summary. Note that it may be a good idea to do that for the external reference list too if that PR is taken.

Component summaries are sometimes but not always superfluous, same for sentence summaries.

Some Paragraph summaries are too short, some are unclear, some are more motivation than summary. I'll try to cover those in another pass.

LongForWisdom and others added 2 commits April 16, 2020 00:34
- Changed General and Technical Template to include Sentence Summary, Paragraph Summary, Component Summary.
- Removed Component List and old Summary heading from the General and Technical templates.
- Changed all MIPs to follow the new templates.
- Wrote sentence summaries for each MIP.
- Paragraph Summaries for each MIP are a direct copy of the previous summaries.
- Wrote component summaries for each component in each MIP.
@CPSTL
Copy link
Contributor

CPSTL commented Apr 17, 2020

Thanks for adding that. Helps with the Clarity principle :)

@CPSTL CPSTL merged commit 2dfa945 into makerdao:master Apr 17, 2020
CPSTL pushed a commit that referenced this pull request Apr 27, 2020
Merge latest from master.
@LongForWisdom LongForWisdom deleted the Summaries branch May 18, 2020 12:52
CPSTL pushed a commit that referenced this pull request Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants