Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unhide migration banner for delegators & only count v2 renewals for delegator migration #949

Merged
merged 3 commits into from
Nov 20, 2024

Conversation

tyler17
Copy link
Collaborator

@tyler17 tyler17 commented Oct 24, 2024

No description provided.

Copy link

vercel bot commented Oct 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
governance-portal-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 20, 2024 10:15pm

Copy link

what-the-diff bot commented Oct 24, 2024

PR Summary

  • Refactoring fetchDelegatedTo.ts Module
    This change has updated a property named isRenewed to isRenewedToV2. Now, this property evaluates whether the renewed contract employs the upgraded format, specifically version 2.

  • Updating delegate.d.ts Type Definitions
    The DelegationHistoryWithExpirationDate type definition now uses the renamed version of the property isRenewed, called isRenewedToV2, providing consistency with other parts of the code.

  • Fine-tuning MigrationBanner.tsx Display Logic
    For managing the display of the migration banner, the showDelegationMigrationBanner function has been updated. The function now includes the condition for the presence of older, version 1 contracts in its display logic.

  • Simplifying Logic in useMigrationStatus.tsx
    Previously, this module included checks for expired or expiring delegated contracts. With this update, such checks have been removed, simplifying the flow. Furthermore, it now utilises the isRenewedToV2 property for detecting whether a contract is of the older, version 1 format.

@tyler17 tyler17 changed the title unhide migration banner for delegators unhide migration banner for delegators & only count v2 renewals for delegator migration Oct 25, 2024
@tyler17 tyler17 merged commit f2c44d8 into develop Nov 20, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants