Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tenderly updates #906

Merged
merged 2 commits into from
Aug 5, 2024
Merged

Tenderly updates #906

merged 2 commits into from
Aug 5, 2024

Conversation

tyler17
Copy link
Collaborator

@tyler17 tyler17 commented Aug 5, 2024

skip mock connector code if USE_MOCK_WALLET isn't true or if NODE ENV is production

Copy link

vercel bot commented Aug 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
governance-portal-v2 ✅ Ready (Inspect) Visit Preview Aug 5, 2024 4:07pm

Copy link

what-the-diff bot commented Aug 5, 2024

PR Summary

  • Creation of a Mock Connection
    The developer team has added a conditional statement that checks for certain settings in the software's configuration. If these settings are specific values, the code will create and utilize a 'mock Connection'. A mock connection is essentially a simulated connection used for testing purposes.

  • Updating Supported Wallets
    Again, based on specific configuration settings, the code has been updated to include 'mock' as a supported type of connection within the system. This allows for wider testing and simulation capabilities.

  • Change in Function Execution
    An update to the 'useTenderlyWindowBindings' function ensures that the code within will only execute under certain settings. This is designed to restrict the function's execution to specific conditions for more controlled programming behavior.

Copy link
Collaborator

@b-pmcg b-pmcg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great! Errors gone

@tyler17 tyler17 merged commit ea3a39d into master Aug 5, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants