Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Liquidity fixes #901

Merged
merged 4 commits into from
Jul 26, 2024
Merged

Liquidity fixes #901

merged 4 commits into from
Jul 26, 2024

Conversation

tyler17
Copy link
Collaborator

@tyler17 tyler17 commented Jul 24, 2024

Hardcode two Uniswap V3 pools and check their MKR balance (The next largest v3 pool only has 3 MKR in it so I think it's fine to hardcode the two popular ones. We're doing the same for uniswap V2).

Update the balancer subgraph url, and also add support for balancer V2.

Copy link

vercel bot commented Jul 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
governance-portal-v2 ✅ Ready (Inspect) Visit Preview Jul 25, 2024 5:06am

Copy link

what-the-diff bot commented Jul 24, 2024

PR Summary

  • Added Keys in Configuration Files
    In the config.ts and .env.sample files, keys for accessing the Subgraph API have been added, which will be used in our data fetching process. This API key serves as our primary access point for getting data from the Subgraph database.

  • Removed Unused File
    The uniswapV3MkrSupply.ts file has been deleted because it is no longer used in the project.

  • Updated Component: MkrLiquiditySidebar
    The MkrLiquiditySidebar.tsx file was heavily updated. These updates mainly involve:

    • Importing configuration data that will be useful later in the code.
    • Addition of two new variables namely uniswapV3MkrEthPointThreePercentPool and uniswapV3MkrEthOnePercentPool.
    • Modification of the data fetching method, getBalancerV1Mkr, to now use our new Subgraph API key for getting data.
    • Addition of a new async function getBalancerV2Mkr, that will perform another kind of data fetching operation; specific to Balancer V2 MKR.
    • Modification in React's useSWR hook to fetch data using the updated getBalancerV1Mkr and the newly added getBalancerV2Mkr methods.
    • Updating the mkrPools array to include values acquired from the balancerV1 and balancerV2 data fetching methods, allowing for more comprehensive data on the pools.

Copy link
Collaborator

@b-pmcg b-pmcg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great! nice to have this back

@adamgoth adamgoth merged commit f4fed1c into develop Jul 26, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants