Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add UniswapV2 contract addresses #22

Merged
merged 3 commits into from
Mar 28, 2022
Merged

Add UniswapV2 contract addresses #22

merged 3 commits into from
Mar 28, 2022

Conversation

valiafetisov
Copy link
Collaborator

As per discussion on Discord: let's keep latest contract addresses in the repo in a machine-readable format so it can be shared across other projects.

File format proposal:

  • Format: JSON
  • Filename: /addresses.json
  • Root keys: chain ids in a hex format
  • Sub keys: contract names

@valiafetisov valiafetisov mentioned this pull request Jan 31, 2022
Closed
13 tasks
godsflaw
godsflaw approved these changes Mar 28, 2022
View reviewed changes
Copy link
Contributor

@godsflaw godsflaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

going to merge this, then make an update for the addresses.

We should also echo a note in the deploy script to update this file (or even do it automatically).

@godsflaw godsflaw merged commit 0e3c637 into makerdao:master Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@godsflaw godsflaw godsflaw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@valiafetisov @godsflaw