Add example deploy scripts for reference #29
Conversation
|
|
||
| echo "Set permissions..." | ||
|
|
||
| seth send $CROPPER 'rely(address)' $MCD_PAUSE_PROXY |
There was a problem hiding this comment.
Still just glancing but might be good to check here that MCD_PAUSE_PROXY is not empty (also a in the other script).
Just to avoid this failing, then denying and having to redeploy.
There was a problem hiding this comment.
or we can just use the chainlog to get the pause proxy addr
|
|
||
| echo "Deploying contracts..." | ||
|
|
||
| CROPPER=$(dapp create Cropper) |
There was a problem hiding this comment.
Maybe adding the gas limit for each call or one that covers the maximum one?
As by default it will try to run with 200K and the contract creation ones will fail.
| # | ||
| # Usage: ./deploy-cropper.sh | ||
| #################################################### | ||
|
|
There was a problem hiding this comment.
Subjective so just fyi -
Might be useful to add "set -x" at the top of such scripts as it echoes each command and you can see the actual seth commands performed with the actual addresses.
Problem here is that it will also echo the echo commands, so these will be printed twice.
But you can maybe remove them.
Anw feel free to ignore :)
Helpful for reference when doing a deploy.