Skip to content
This repository has been archived by the owner on Sep 28, 2022. It is now read-only.

Use testchain-dss-deployment-scripts in testchain #90

Merged
merged 5 commits into from
Mar 27, 2019

Conversation

levity
Copy link
Contributor

@levity levity commented Mar 27, 2019

No description provided.

levity added 4 commits March 26, 2019 12:05
this solves the issue of seeing two failures for each test in test output when beforeAll fails

jestjs/jest#6695
this revises the lib to match step 1 deployment from testchain-dss-deployment-scripts, except with price feeds deployed as DSValue

this means the default collateral type shrinks to ETH-A, ETH-B, COL1-A

this also adapts to some renames in Jug: tax => duty, repo => base
@levity levity mentioned this pull request Mar 27, 2019
This reverts commit 6e12327.
@codecov-io
Copy link

Codecov Report

Merging #90 into dev will decrease coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev      #90      +/-   ##
==========================================
- Coverage   92.99%   92.92%   -0.08%     
==========================================
  Files          64       64              
  Lines        1814     1810       -4     
==========================================
- Hits         1687     1682       -5     
- Misses        127      128       +1
Impacted Files Coverage Δ
lib/dai-plugin-mcd/test/helpers.js 81.03% <ø> (ø) ⬆️
lib/dai-plugin-mcd/src/index.js 100% <ø> (ø) ⬆️
lib/dai-plugin-mcd/src/CdpType.js 100% <100%> (ø) ⬆️
lib/dai-plugin-mcd/src/SystemDataService.js 100% <100%> (ø) ⬆️
src/eth/TransactionManager.js 95.28% <0%> (-0.95%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 557b44a...6afa983. Read the comment docs.

@levity levity merged commit aba0e98 into dev Mar 27, 2019
@levity levity deleted the testchain-dss-deployment-scripts branch March 27, 2019 04:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants