Skip to content
This repository was archived by the owner on Sep 28, 2022. It is now read-only.

Update gas price fields for 1559 #315

Merged
merged 1 commit into from
Dec 15, 2021
Merged

Update gas price fields for 1559 #315

merged 1 commit into from
Dec 15, 2021

Conversation

adamgoth
Copy link
Collaborator

@adamgoth adamgoth commented Dec 13, 2021

Instead of setting gasPrice, we set maxFeePerGas and maxPriorityFeePerGas. maxPriorityFeePerGas is hardcoded to 2.5 gwei.

More info for the gas fields expected in web3 sendTransaction: https://web3js.readthedocs.io/en/v1.5.2/web3-eth.html#sendtransaction

More info for changes from infura: https://blog.infura.io/london-fork/

@codecov
Copy link

codecov bot commented Dec 13, 2021

Codecov Report

Merging #315 (1e184b5) into dev (018cbbb) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #315   +/-   ##
=======================================
  Coverage   86.15%   86.16%           
=======================================
  Files         139      139           
  Lines        6351     6352    +1     
  Branches     1263     1263           
=======================================
+ Hits         5472     5473    +1     
  Misses        873      873           
  Partials        6        6           
Impacted Files Coverage Δ
packages/dai/src/eth/TransactionManager.js 91.25% <100.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 018cbbb...1e184b5. Read the comment docs.

@adamgoth adamgoth marked this pull request as ready for review December 13, 2021 15:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants