Skip to content
This repository has been archived by the owner on Sep 28, 2022. It is now read-only.

explicitly add value property to tx options #189

Merged
merged 2 commits into from
Nov 21, 2019
Merged

Conversation

levity
Copy link
Contributor

@levity levity commented Nov 21, 2019

No description provided.

@levity
Copy link
Contributor Author

levity commented Nov 21, 2019

LGTM--I'll publish a release candidate version of the library with this so we can test it out on the migration dashboard.

@codecov-io
Copy link

Codecov Report

Merging #189 into dev will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##              dev    #189      +/-   ##
=========================================
+ Coverage   92.49%   92.5%   +<.01%     
=========================================
  Files          87      87              
  Lines        2439    2441       +2     
=========================================
+ Hits         2256    2258       +2     
  Misses        183     183
Impacted Files Coverage Δ
packages/dai/src/eth/TransactionManager.js 89.16% <100%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6035dd6...24742dd. Read the comment docs.

@levity levity merged commit ae1b2a0 into dev Nov 21, 2019
@b-pmcg b-pmcg deleted the gnosis-walletconnect-fix branch January 10, 2020 08:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants