Skip to content
This repository has been archived by the owner on Sep 28, 2022. It is now read-only.

CDP-342 - check that default account exists before checking against a… #135

Merged
merged 1 commit into from
Jul 11, 2019

Conversation

abylaw
Copy link
Contributor

@abylaw abylaw commented Jul 5, 2019

…ccount address

@abylaw abylaw requested review from levity, b-pmcg and ethanbennett July 5, 2019 05:40
@codecov-io
Copy link

codecov-io commented Jul 5, 2019

Codecov Report

Merging #135 into dev will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #135   +/-   ##
=======================================
  Coverage   91.81%   91.81%           
=======================================
  Files          63       63           
  Lines        1856     1856           
=======================================
  Hits         1704     1704           
  Misses        152      152
Impacted Files Coverage Δ
packages/dai/src/eth/AccountsService.js 98.7% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70ee726...2365d4d. Read the comment docs.

@abylaw abylaw force-pushed the CDP-342-browser-connect branch from fc271a6 to d92ff8f Compare July 11, 2019 09:31
@abylaw abylaw force-pushed the CDP-342-browser-connect branch from d92ff8f to 2365d4d Compare July 11, 2019 09:38
@abylaw abylaw merged commit 36377e4 into dev Jul 11, 2019
@abylaw abylaw deleted the CDP-342-browser-connect branch July 11, 2019 09:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants