Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create atlas weekly edit poll #2787

Merged
merged 2 commits into from
Nov 11, 2024
Merged

Conversation

0xldr
Copy link
Collaborator

@0xldr 0xldr commented Nov 11, 2024

No description provided.

@0xldr 0xldr requested a review from MakerJanSky November 11, 2024 13:39
Copy link
Collaborator

@MakerJanSky MakerJanSky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, ldr.

@MakerJanSky
Copy link
Collaborator

Poll Review

Admin I

  • Is the poll expected this week?
  • Do you understand the question the poll is asking of governance?

Content

  • Does the filename have the .md extension?
  • Does the filename contain banned characters? <>:"/?*|
  • Do the titles contain banned characters? <>:"/?*
  • Are the poll options too long? (Less than 30 characters as a rough guide)
  • Do the options have distinct numbers in the preamble?
  • Are the start and end dates present and correct?
  • Does the vote type match desired vote type for the poll?
  • Is the default option correct in metadata?
  • Is the preamble ready for submission?
  • Is the vote descriptor present and does it match the vote type?
  • Are the 'Review', 'Outcomes', and 'Resources' sections present?
  • Will the Data/parameters present in the poll be accurate at the time the poll is live?
  • Are the dates correct within the text?
  • Are all the relevant links provided?
  • Are all the links working?
  • Are the outcomes clear and comprehensive?
  • Do any '$' parameter signifiers remain?
  • Does the poll summary accurately reflect the poll content?
  • Read the poll text in full and highlight any other potential issues.

Admin II

  • Raise any issues with the poll author via review on GitHub.
  • Inform the reviewer when the poll passes review.

Copy link
Collaborator

@MakerJanSky MakerJanSky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Job well done.

@MakerJanSky MakerJanSky merged commit 47b2434 into makerdao:master Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants