Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add spell address #2760

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Add spell address #2760

merged 1 commit into from
Oct 4, 2024

Conversation

CivicSage3
Copy link
Collaborator

No description provided.

@CivicSage3 CivicSage3 requested review from 0xldr and VoteWizard October 4, 2024 16:51
0xldr
0xldr approved these changes Oct 4, 2024
View reviewed changes
Copy link
Collaborator

@0xldr 0xldr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have checked the address matches the address supplied in #new-spells on Discord.

We have also performed a review of the deployed code on Etherscan which matches the GitHub code and contains all expected items from the spell planning sheet.

@VoteWizard VoteWizard merged commit 838387b into makerdao:master Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xldr 0xldr 0xldr approved these changes

@VoteWizard VoteWizard Awaiting requested review from VoteWizard

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CivicSage3 @0xldr @VoteWizard