Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add polls #2732

Merged
merged 7 commits into from
Sep 9, 2024
Merged

add polls #2732

merged 7 commits into from
Sep 9, 2024

Conversation

0xldr
Copy link
Collaborator

@0xldr 0xldr commented Sep 8, 2024

No description provided.

governance/polls/Atlas v2 Upgrade - September 9, 2024.md Outdated Show resolved Hide resolved
* New Token contracts and corresponding token converters
* [USDS](https://github.com/makerdao/sdai/tree/susds) (Upgraded DAI)
* [SKY](https://github.com/makerdao/sky) (Upgraded MKR)
* The introduction of the [Sky Savings Rate (sUSDS)](https://github.com/makerdao/sdai/tree/snst)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* The introduction of the [Sky Savings Rate (sUSDS)](https://github.com/makerdao/sdai/tree/snst)
* The introduction of the [Sky Savings Rate (sUSDS)](https://github.com/makerdao/sdai/tree/susds)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a typo, we believe it is intentional to link to the snst branch as this is the branch and commit that was audited


The community can vote in this poll to express support or opposition to the following changes. In summary, this vovers the following items (find attached corresponding GitHub Repos, which include README files that explain all technical details):

* New Token contracts and corresponding token converters
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* New Token contracts and corresponding token converters
* New Token contracts and corresponding token converters initializtion.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this list is generally a bit inconsistent in form. There are:

  • verbal forms ("Use USDS to get SKY").
  • nominalized forms ("SBE Upgrade")
  • Some of the nominalized forms are 100% noun compounds, some are not ("The introduction of STR" in contrast to "STR introduction").

Additionally, list items are missing a period at the end and capitalization is inconsistent.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general we have tried to keep the wording as close to the post from BA Labs as possible. This is to ensure there is no ambiguity if the text differs between the two sources.


### Deployment Requirements Before Token and Product Launch Spell

* Tokens:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This list is inconsistent in a similar fashion.

I don't think the requirements are very clear. What does it mean that "Splitter" is required?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above comment

Copy link
Collaborator

@MakerJanSky MakerJanSky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, ldr.

@0xldr 0xldr merged commit 34645c4 into makerdao:master Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants