-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add polls #2732
add polls #2732
Conversation
... Protocol Launch Season - Token and Product Launch Parameter Proposal - September 9, 2024.md
Outdated
Show resolved
Hide resolved
* New Token contracts and corresponding token converters | ||
* [USDS](https://github.com/makerdao/sdai/tree/susds) (Upgraded DAI) | ||
* [SKY](https://github.com/makerdao/sky) (Upgraded MKR) | ||
* The introduction of the [Sky Savings Rate (sUSDS)](https://github.com/makerdao/sdai/tree/snst) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* The introduction of the [Sky Savings Rate (sUSDS)](https://github.com/makerdao/sdai/tree/snst) | |
* The introduction of the [Sky Savings Rate (sUSDS)](https://github.com/makerdao/sdai/tree/susds) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a typo, we believe it is intentional to link to the snst branch as this is the branch and commit that was audited
|
||
The community can vote in this poll to express support or opposition to the following changes. In summary, this vovers the following items (find attached corresponding GitHub Repos, which include README files that explain all technical details): | ||
|
||
* New Token contracts and corresponding token converters |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* New Token contracts and corresponding token converters | |
* New Token contracts and corresponding token converters initializtion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this list is generally a bit inconsistent in form. There are:
- verbal forms ("Use USDS to get SKY").
- nominalized forms ("SBE Upgrade")
- Some of the nominalized forms are 100% noun compounds, some are not ("The introduction of STR" in contrast to "STR introduction").
Additionally, list items are missing a period at the end and capitalization is inconsistent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general we have tried to keep the wording as close to the post from BA Labs as possible. This is to ensure there is no ambiguity if the text differs between the two sources.
|
||
### Deployment Requirements Before Token and Product Launch Spell | ||
|
||
* Tokens: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This list is inconsistent in a similar fashion.
I don't think the requirements are very clear. What does it mean that "Splitter" is required?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See above comment
... Protocol Launch Season - Token and Product Launch Parameter Proposal - September 9, 2024.md
Outdated
Show resolved
Hide resolved
... Protocol Launch Season - Token and Product Launch Parameter Proposal - September 9, 2024.md
Outdated
Show resolved
Hide resolved
Co-authored-by: blimpa <[email protected]> Co-authored-by: MakerJanSky <[email protected]>
This reverts commit 2738441.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, ldr.
No description provided.