Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ad info update 2024 08 #2723

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

boet1
Copy link
Contributor

@boet1 boet1 commented Aug 21, 2024

The following changes were made:

  • New delegate contracts were added
  • Incorrect delegate addresses were replaced with the correct ones
  • Unused contract folders were deleted
  • Each delegate's metrics were updated

@VoteWizard

@boet1 boet1 mentioned this pull request Aug 21, 2024
Error in using 'No Data' for an old delegate.
Copy link
Collaborator

@0xldr 0xldr Aug 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the delegate migration process creates automatic links between delegate contracts without the need for updating folders like this. This is why 0x24419b100Bd4f5C581c0AA89A274fcfB5B3915a8 displays as Cloaky on the voting portal already:

image

The links appear to be stored in this file for use by the backened - https://github.com/makerdao/governance-portal-v2/blob/master/modules/migration/delegateAddressLinks.ts#L11

We strongly suggest that any changes to the folder structure are discussed with Jetstream before merging this Pull request.

@DaiFoundation-DevOps
Copy link

DaiFoundation-DevOps commented Oct 8, 2024

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants