Skip to content
This repository has been archived by the owner on Oct 8, 2024. It is now read-only.

godsflaw-20220527: add WSTETH-B and update ETH->DAI routes #63

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

godsflaw
Copy link
Contributor

this change:

  • adds WSTETH-B to the keeper
  • updates the routes from ETH->DAI to go through USDC (less gas efficient, but less slippage)
  • updates the minimum gas by +4 million as anything less got out-of-gas errors for this circuit.

@godsflaw godsflaw added the enhancement New feature or request label May 27, 2022
@godsflaw godsflaw requested a review from talbaneth May 27, 2022 14:58
@godsflaw godsflaw self-assigned this May 27, 2022
},
{
"fee": 100,
"tokenA": "0xA0b86991c6218b36c1d19D4a2e9Eb0cE3606eB48",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still testing if this path works. The more advanced path did not work for WSTETH, so it may not work here. Not sure why yet.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, the more advanced routing doesn't work.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good:

  • Verified chosen pools volumes are highest in https://info.uniswap.org/#/pools
  • Verified mainnet.json changed ilks are what we expect (all but ilks using univ2, WSTETH-A and WSTETH-B which are not supported in callee level and CRVV1ETHSTETH-A which was lacking support in auction-demo-keeper logic).
  • Verified succesfull liquidations for ETH-A, ETH-B, RENBTC-A.

I opened a PR to support also CRVV1ETHSTETH-A - #64.
Would be nice to merge it to this branch.

I'll also create 2 new tasks:

  1. Supporting kicking curve lp (and charter later) auctions more easily with kick_auctions.sh script (or a similar one if we can't integrate it nicely there). The reason for it not to be currently supported seamlessly is that cropper and charter use the cdp registry (and not the the cdp manager).

  2. Changing the WSTETH callee contract to support a complex path. This includes support in auction demo keeper when the new callee is deployed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants