Support oauth token endpoint, add wiki verification support, fix issue #420 #438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with toggleable heading type
rhart92
changed the title
| verified_by: null | ||
| } | ||
|
|
||
| type VerificationPropertyResponse = { |
There was a problem hiding this comment.
is it auto-generated?
| @@ -525,6 +553,29 @@ export default class Client { | |||
| }) | |||
| } | |||
|
|
|||
| public readonly oauth = { | |||
There was a problem hiding this comment.
Allows you to call the token endpoint.
const { Client } = require("@notionhq/client")
// Initializing a client
const notion = new Client({ ... })
const tokenResponse = await notion.oauth.token({ ... })This is similar to how we nest all the block methods under a blocks object.
There was a problem hiding this comment.
hmm... we were not allowed to call the token endpoint before your change?
There was a problem hiding this comment.
Not through the SDK 😓 See #73
hazel-notion
approved these changes
Aug 11, 2023
Merged
rhart92
added a commit
that referenced
this pull request
Oct 3, 2023
…with toggleable heading type (#438)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #420 and #73.