Add update database to client #170
Conversation
src/api-endpoints.ts
Outdated
| extends DatabasesUpdatePathParameters, | ||
| DatabasesUpdateQueryParameters, | ||
| DatabasesUpdateBodyParameters {} | ||
| export interface DatabasesUpdateResponse extends BlockBase {} |
There was a problem hiding this comment.
This returns a Database object right? not BlockBase?
There was a problem hiding this comment.
good catch, fixed!
| @@ -1040,3 +1040,28 @@ export interface LastEditedTimePropertySchema { | |||
| export interface LastEditedByPropertySchema { | |||
There was a problem hiding this comment.
This is not part of the PR, but why is this a PropertySchema? this shouldn't be editable right?
There was a problem hiding this comment.
Same for | CreatedTimePropertySchema | CreatedByPropertySchema | LastEditedTimePropertySchema | LastEditedByPropertySchema
There was a problem hiding this comment.
these can be added to the database schema as properties, the values themselves are not updated
src/api-types.ts
Outdated
| } | ||
|
|
||
| export interface UpdateMultiSelectPropertySchema { | ||
| multi_select: { options?: UpdateMultiSelectOptionSchema[] } |
There was a problem hiding this comment.
Why have a separate type for the mulitselect options?
There was a problem hiding this comment.
good point - updated so both use the same type
| type UpdateSelectOptionSchema = SelectOptionSchema | SelectOption | ||
|
|
||
| export interface UpdateSelectPropertySchema { | ||
| select: { options?: UpdateSelectOptionSchema[] } |
There was a problem hiding this comment.
the options field is nullable? what's the behavior when an empty object is passed into select?
There was a problem hiding this comment.
if it's undefined, then there will be no options (similar to when you create a "select" property in the client before adding any options). In create database, the options are optional (ha).
* Add update database to client * Fix typo * Change response to Database * Use the same type for both select and multi select options
Adding support for update database: https://developers.notion.com/reference/update-a-database