TST: Check pytables<3.5.1 when skipping (pandas-dev#25773)

* TST: Check pytables<3.5.1 when skipping 3.5.1 was made available on conda, causing 'xfail_non_writeable' tests to fail. * TST: Skip geopandas downstream test xref pandas-devgh-25778
makeajourney · Mar 19, 2019 · c975fc4 · c975fc4
1 parent c8ba766
commit c975fc4
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/pandas/tests/io/test_pytables.py b/pandas/tests/io/test_pytables.py
@@ -38,7 +38,8 @@
 # remove when gh-24839 is fixed; this affects numpy 1.16
 # and pytables 3.4.4
 xfail_non_writeable = pytest.mark.xfail(
-    LooseVersion(np.__version__) >= LooseVersion('1.16'),
+    LooseVersion(np.__version__) >= LooseVersion('1.16') and
+    LooseVersion(tables.__version__) < LooseVersion('3.5.1'),
     reason=('gh-25511, gh-24839. pytables needs a '
             'release beyong 3.4.4 to support numpy 1.16x'))
 

diff --git a/pandas/tests/test_downstream.py b/pandas/tests/test_downstream.py
@@ -118,6 +118,7 @@ def test_pandas_datareader():
 @pytest.mark.filterwarnings("ignore:The 'warn':DeprecationWarning")
 @pytest.mark.filterwarnings("ignore:pandas.util:DeprecationWarning")
 @pytest.mark.filterwarnings("ignore:can't resolve:ImportWarning")
+@pytest.mark.skip(reason="gh-25778: geopandas stack issue")
 def test_geopandas():
 
     geopandas = import_module('geopandas')  # noqa