Add steps to switch between sessions #142
Conversation
CHANGELOG.md
Outdated
| @@ -3,6 +3,9 @@ All notable changes to this project will be documented in this file. | |||
|
|
|||
| This project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html). | |||
|
|
|||
| ## Unreleased | |||
| - Add a step modifier to control different sessions: `... in the browser session "..."`. (see issue [#66](https://github.com/makandra/spreewald/issues/66)) | |||
There was a problem hiding this comment.
| - Add a step modifier to control different sessions: `... in the browser session "..."`. (see issue [#66](https://github.com/makandra/spreewald/issues/66)) | |
| - Add a step modifier to control different Capybara sessions: `... in the browser session "..."`. (see issue [#66](https://github.com/makandra/spreewald/issues/66)) |
lib/spreewald/session_steps.rb
Outdated
| end.overridable | ||
|
|
||
| # nodoc | ||
| When /^(.*) in the browser session "([^"]+):$/ do |nested_step, session_name, table_or_string| |
There was a problem hiding this comment.
I'm glad you thought about the interoperability with table steps!
Please add a test for this step as well.
| Feature: Browser session steps | ||
|
|
||
| Background: Access some content in the main session | ||
| Given I go to "/static_pages/tab_1" |
There was a problem hiding this comment.
Please don't introduce a Background if it's only used by a single Scenario
| Given I go to "/static_pages/tab_1" | ||
| Then I should see "First browser tab" | ||
|
|
||
| Scenario: Browser sessions do not interfere with each other |
There was a problem hiding this comment.
Please add new minimal static pages for this test. It's irritating to read about browser tabs when they do not matter at all
| Given I go to "/static_pages/tab_1" | ||
| Then I should see "First browser tab" | ||
|
|
||
| Scenario: Browser sessions do not interfere with each other |
There was a problem hiding this comment.
When you are checking multiple assertions in a single scenario, express the assertion as a comment.
In this case, I would group it sth. like this:
# Different pages can be accessed on different browser sessions
..
I should see "second session" in the browser session "Second browser session"
...
# The default session is not affected by actions in other sessions
Then I should not see "Second browser session"
And I should not see "Third browser session"
# Other sessions are not affected by the default session
...
|
|
||
| Then I should see "Second browser tab" in the browser session "second" | ||
| And I should see "Third browser tab" in the browser session "third" | ||
| But I should not see "First browser tab" in the browser session "second" |
There was a problem hiding this comment.
| But I should not see "First browser tab" in the browser session "second" | |
| But I should not see "First browser tab" in the browser session "second" |
| @@ -0,0 +1 @@ | |||
| ../../shared/features/shared/browser_tab_steps.feature | |||
There was a problem hiding this comment.
I thought all shared features are already symlinked through their hierarchy, isn't that so?
| @@ -286,6 +286,18 @@ the step definitions. | |||
| This step is deprecated and will be removed from spreewald. If you still want to use it, copy the code to your project's own steps. | |||
|
|
|||
|
|
|||
| ### session_steps.rb | |||
There was a problem hiding this comment.
👍 Good description! Thanks for moving things to a separate file.
Closes #66