Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix 'the window should be titled' step - closes: #102 #105

Merged
merged 1 commit into from
Jul 15, 2019

Conversation

ThomasT-makandra
Copy link
Contributor

No description provided.

Copy link
Contributor

@judithroth judithroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As written in the comments please add a second test without the javascript tag and ensure that both are working. Apart from that I'm very happy with your code!

lib/spreewald/web_steps.rb Outdated Show resolved Hide resolved
@ThomasT-makandra ThomasT-makandra force-pushed the tt/fix_the-window-should-be-titled_step branch from be8cc55 to 4b03f71 Compare July 15, 2019 09:59
@ThomasT-makandra ThomasT-makandra merged commit ad23bf6 into master Jul 15, 2019
@ThomasT-makandra ThomasT-makandra deleted the tt/fix_the-window-should-be-titled_step branch July 15, 2019 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants