Refactor the 'I should see the number' step #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
judithroth
reviewed
Jun 13, 2019
judithroth
reviewed
Jun 13, 2019
judithroth
reviewed
Jun 13, 2019
| nbsp = " " | ||
| "( |#{nbsp})(#{unit})" | ||
| else | ||
| word_boundary |
There was a problem hiding this comment.
It's just a minor thing but I don't see the value of using a variable here. I guess it is a leftover of changing things. I would prefer to have the '\b' directly in the else clause.
judithroth
reviewed
Jun 13, 2019
lib/spreewald/web_steps.rb
Outdated
| expectation = negate ? :not_to : :to | ||
| expect_to_match = negate ? :not_to : :to | ||
| amount_included_minus = amount.gsub!(/^-/, '') | ||
| expect_minus = amount_included_minus ? '-' : '(?:[^\\-]|^)' |
There was a problem hiding this comment.
'(?:[^\\-]|^)' what is the added |^ for?
|
Overall I really like what you did, good job! I made some comments - if you want to we can talk about those. |
* It can now be composed with the 'within' step * It can now truly match negative numbers * It dropped the hidden dependency on the HTMLEntities gem * It is now tested
makmic
force-pushed
the
ml/update-see-the-amount
branch
from
26b4542 to
ebce7b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issues #43 and #44.
Please note that I had to switch from
page.bodytopage.text, since the former is not affected by the scope that was created by a within step.