Remove ruby 2.4.5 support

makandra · Aug 19, 2021 · 92eb62b · 92eb62b
1 parent 0d3af62
commit 92eb62b
Show file tree

Hide file tree

Showing 61 changed files with 5 additions and 1,049 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -14,14 +14,9 @@ jobs:
       fail-fast: false
       matrix:
         include:
-        # Test projects
-        - ruby: 2.4.5
-          gemfile: tests/rails-4_capybara-2/Gemfile
         - ruby: 3.0.0
           gemfile: tests/rails-6_capybara-3/Gemfile
         # Used to run rspec and integration tests for spreewald binary:
-        - ruby: 2.4.5
-          gemfile: Gemfile.ruby245
         - ruby: 2.6.6
           gemfile: Gemfile.ruby266
         - ruby: 3.0.0

diff --git a/Gemfile.ruby245 b/Gemfile.ruby245
diff --git a/Gemfile.ruby245.lock b/Gemfile.ruby245.lock
diff --git a/README.md b/README.md
@@ -21,7 +21,7 @@ Or install it yourself as:
 
 ## Supported versions
 
-Spreewald is currently tested against Ruby 2.4.5 with Rails 4 and Capybara 2 and Ruby 2.6.6 with Rails 6 and Capybara 3.
+Spreewald is currently tested against and Ruby 2.6.6 with Rails 6 and Capybara 3.
 
 ## Usage
 

diff --git a/Rakefile b/Rakefile
@@ -72,15 +72,7 @@ end
 
 def cucumber_command(directory, ruby_version)
   command = "cd #{directory} && BUNDLE_GEMFILE=Gemfile bundle exec cucumber --publish-quiet"
-  if Gem::Version.new(ruby_version) > Gem::Version.new('2.5')
-    # Modern cucumber sees pending tests as failures.
-    # We don't want this.
-    command << ' --no-strict-pending'
-  else
-    # Ruby < 2.5 means the capybara 2 Test project.
-    # Omit scenarios that only work with modern Capybara.
-    command << ' --tags "not @not-capybara-2"'
-  end
+  command << ' --no-strict-pending'
   command
 end
 

diff --git a/lib/spreewald_support/version.rb b/lib/spreewald_support/version.rb
@@ -1,3 +1,3 @@
 module Spreewald
-  VERSION = '4.2.2'
+  VERSION = '4.2.3'
 end
diff --git a/tests/rails-4_capybara-2/Gemfile b/tests/rails-4_capybara-2/Gemfile
diff --git a/tests/rails-4_capybara-2/Gemfile.lock b/tests/rails-4_capybara-2/Gemfile.lock