Mariadb-sys referenced in suggestions doesn't support Maria DB 10.x

[meek2100]

This link for mariadb-sys doesn't support Maria DB only supports 10.0.x - https://github.com/good-dba/mariadb-sys

Probably need to update it to a more recently updated repo like https://github.com/FromDual/mariadb-sys that supports 10.x versions of Maria DB.

According to https://fromdual.com/mariadb-sys-schema they say https://github.com/FromDual/mariadb-sys supports up to 10.4 at the time of writing the article.

[meek2100]

Looks like the latest changes has this code, but it doesn't appear to be working with MariaDB 10.4.14 installed on my Cent OS 8 VPS server.

"Performance schema shouldn't be activated for MariaDB 10.0 for performance issue" ); push( @adjvars, "performance_schema = OFF disable PFS" ); return; } unless ( grep /^sys$/, select_array("SHOW DATABASES") ) { infoprint "Sys schema isn't installed."; push( @generalrec, "Consider installing Sys schema from https://github.com/mysql/mysql-sys for MySQL" ) unless ( mysql_version_le( 5, 6 ) ); push( @generalrec, "Consider installing Sys schema from https://github.com/FromDual/mariadb-sys for MariaDB" ) unless ( mysql_version_eq( 10, 0 ) or mysql_version_eq( 5, 5 ) );

[grooverdan]

Was fixed in #466

[grooverdan]

Upstream fix submitted to support 10.5 - FromDual/mariadb-sys#2 . Once that is accepted/not then some more changing of wording can occur.

[FabioPedretti]

Since 10.6 the sys schema is included in MariaDB: https://jira.mariadb.org/browse/MDEV-9077

[grooverdan]

The existing MySQLTuner checks for the existance of the sys schema, so the MariaDB-10.6+ case is already taken care of.

The only broken case is the 10.5 as FromDual/mariadb-sys#2 isn't merged.

So the only remaining change needed is removing 10.5 from the versions in which to recommend adding the sys schema.

[jmrenouard]

This issue is related to this one: ERROR 1054 #615
All fixes and details in ERROR 1054 #615 issue comments