feat: check pre-requisites on OSSM plugin init #7
Conversation
|
Also, I added the latest SMCP entire CRD - let me know if I should add a truncated one instead. |
pkg/kfapp/ossm/k8s_resources.go
Outdated
| // CreateSMCP uses dynamic client to create a dummy SMCP for testing | ||
| func (o *OssmInstaller) CreateSMCP(namespace string, smcpObj *unstructured.Unstructured) error { |
There was a problem hiding this comment.
I would move it to test code as it's only used for testing purposes.
| err := ossmInstaller.CheckForCRD(crdGroup, crdVersion, crdResource) | ||
|
|
||
| // then | ||
| Expect(err).To(HaveOccurred()) |
There was a problem hiding this comment.
Maybe it would be worth being more specific and also check for message or parts of it?
There was a problem hiding this comment.
good call, added here 06de003
In odh-project-controller, we fetch it as part of |
Co-authored-by: Bartosz Majsak <[email protected]>
Co-authored-by: Bartosz Majsak <[email protected]>
Co-authored-by: Bartosz Majsak <[email protected]>
Co-authored-by: Bartosz Majsak <[email protected]>
Co-authored-by: Bartosz Majsak <[email protected]>
|
I took a look at how CRDs are fetched for project-controller - thanks for linking that. Since I want to get the Dashboard Config patching fixed today I've created another issue to handle this in the future here. PTAL and let me know if that's ok. |
* add prereq checks to init, add tests --------- Co-authored-by: Bartosz Majsak <[email protected]>
* add prereq checks to init, add tests --------- Co-authored-by: Bartosz Majsak <[email protected]>
Creating tests was a bit difficult for the SMCP specifically - please let me know if you see any ways that that process of simulating an SMCP install can be improved.