feat: embed templates into operator plugin #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartoszmajsak
requested changes
Jul 26, 2023
bartoszmajsak
requested changes
Jul 28, 2023
Co-authored-by: Bartosz Majsak <[email protected]>
Co-authored-by: Bartosz Majsak <[email protected]>
bartoszmajsak
requested changes
Jul 31, 2023
pkg/kfapp/ossm/ossm_manifests.go
Outdated
Comment on lines
62
to
65
| const ( | ||
| ControlPlaneDir = "templates/control-plane" | ||
| AuthDir = "templates/authorino" | ||
| ) |
There was a problem hiding this comment.
I would move them next to //go:embed, otherwise they're local per func invocation.
There was a problem hiding this comment.
moved it with the const baseOutputDir in types.go 22c5bd0
bartoszmajsak
approved these changes
Jul 31, 2023
Co-authored-by: Bartosz Majsak <[email protected]>
Co-authored-by: Bartosz Majsak <[email protected]>
Co-authored-by: Bartosz Majsak <[email protected]>
Co-authored-by: Bartosz Majsak <[email protected]>
Co-authored-by: Bartosz Majsak <[email protected]>
bartoszmajsak
added a commit
that referenced
this pull request
Sep 6, 2023
embed templates to OSSM plugin Co-authored-by: Bartosz Majsak <[email protected]>
bartoszmajsak
added a commit
that referenced
this pull request
Sep 6, 2023
embed templates to OSSM plugin Co-authored-by: Bartosz Majsak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR essentially moves the Service Mesh/Authorization specific resource files that were previously found in our manifests fork in the
/service-mesh/folder into the operator's code base.embedfunctionality in golangembedcreates a read only FS, we use/tmp/ossm-installer/ns/kfdef-name/templates/...to create our finalized template yaml filesTo test:
quay.io/maistra-dev/opendatahub-operator:v0.0.5-embed