Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(test): sets up testing for ossm plugin #3

Merged
merged 3 commits into from
Jul 12, 2023

Conversation

bartoszmajsak
Copy link

Run the tests using the new target test-ossm or from the IDE.

Note: due to dependency hell we have to stick with Ginkgo v1 for the time being :(

@cam-garrison
Copy link

Hey @bartoszmajsak, I don't see a reference to the new target test-ossm anywhere in the changes made - am I missing something or have some of the changes not been pushed?

Copy link

@cam-garrison cam-garrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, successfully ran locally with the make target, issues with my IDE running tests but that is a config issue on my part.

pkg/kfapp/ossm/ossm_plugin_test.go Show resolved Hide resolved
@bartoszmajsak bartoszmajsak merged commit 394c243 into kf_ossm_plugin Jul 12, 2023
bartoszmajsak added a commit that referenced this pull request Sep 6, 2023
* chore: removes unused test setup

* feat(test): sets up testing for ossm plugin

* feat(make): adds test-ossm target
bartoszmajsak added a commit that referenced this pull request Sep 6, 2023
* chore: removes unused test setup

* feat(test): sets up testing for ossm plugin

* feat(make): adds test-ossm target
@bartoszmajsak bartoszmajsak deleted the testing_setup branch October 4, 2023 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants