Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(execute): shuts down spawned process on INTERRUPT #1069

Merged
merged 2 commits into from
Aug 11, 2022
Merged

fix(execute): shuts down spawned process on INTERRUPT #1069

merged 2 commits into from
Aug 11, 2022

Conversation

bartoszmajsak
Copy link
Contributor

@bartoszmajsak bartoszmajsak commented Aug 11, 2022 •
edited
Loading

Short description of what this resolves:

Rewrites handling of spawned --run command of ike execute to be based on new hook package. Fixes termination of spawned command.

Changes proposed in this pull request:

  • Failing test to demonstrate the problem
  • Fixes handling of spawned command
  • Cleans up channel/goroutine handling

Fixes #1068

@bartoszmajsak bartoszmajsak added kind/bug Kind: Not working as expected component/cli Component: CLI tooling labels Aug 11, 2022
@bartoszmajsak bartoszmajsak changed the title execute sigterm fix fix(execute): shuts down spawned process on INTERRUPT Aug 11, 2022
@bartoszmajsak bartoszmajsak merged commit 824172d into master Aug 11, 2022
@bartoszmajsak bartoszmajsak deleted the execute_sigterm_fix branch August 11, 2022 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aslakknutsen aslakknutsen aslakknutsen approved these changes

Assignees
No one assigned
Labels
component/cli Component: CLI tooling kind/bug Kind: Not working as expected
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ike execute does not kill spawned process on SIGTERM/SIGINT
2 participants
@bartoszmajsak @aslakknutsen