Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tech-debt: improve ctx passing in reconciler #1101

Open
bartoszmajsak opened this issue Oct 27, 2022 · 0 comments
Open

tech-debt: improve ctx passing in reconciler #1101

bartoszmajsak opened this issue Oct 27, 2022 · 0 comments
Labels
kind/enhancement Kind: New feature or improvement

Comments

@bartoszmajsak
Copy link
Contributor

What can be improved

contextchk reports that we are using non-inherited Context instances in the reconciler code. We should improve it.

Why

To have proper ctx propagation instead of passing empty ones.
@bartoszmajsak bartoszmajsak added the kind/enhancement Kind: New feature or improvement label Oct 27, 2022
bartoszmajsak added a commit that referenced this issue Oct 27, 2022
@bartoszmajsak
chore(lint:contextcheck): disables until #1101 is fixed
46d8395
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement Kind: New feature or improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bartoszmajsak