Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAISTRA-624] Use basic HTTP auth for internal communication #173

Merged
merged 1 commit into from
Aug 6, 2019

Conversation

jwendell
Copy link
Member

@jwendell jwendell commented Jul 30, 2019

Between kiali, grafana, jaeger and prometheus.

This way we can get rid of cluster role bindings.

We create an htpasswd secret unconditionally on the beginning of the control
plane installation, configure all oauth proxies to use that htpasswd
file as another form of authentication and finally configure Kiali
CR to use HTTP basic auth to communicate with those services.

@jpkrohling
Copy link

Jaeger Operator PR: jaegertracing/jaeger-operator#573

@jwendell jwendell marked this pull request as ready for review July 31, 2019 15:09
@jwendell jwendell requested a review from rcernich July 31, 2019 15:24
@objectiser
Copy link
Contributor

@jwendell FYI - the new Jaeger images are listed here, and should hopefully be approved by our QE tomorrow.

Note that the image names have changed.

Copy link
Contributor

@dmitri-d dmitri-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jwendell
Copy link
Member Author

jwendell commented Aug 2, 2019

@objectiser @jpkrohling Are you going to release a new community image with those changes in?

Currently we are installing jaeger operator using the v1.13.1 tag, which points to the image jaegertracing/jaeger-operator:1.13.1.

On my tests, using an image generated by @jpkrohling , I was only able to deploy the jaeger operator if using latest CR's from master (instead of using the v1.13.1 GitHub tag). So, I believe that just pushing a new image to docker hub under the same [floating] 1.13.1 tag is not enough.

@jpkrohling
Copy link

We have a master tag that represents the current state of master. Our plan is to release a new operator version as soon as a new Jaeger version is released, as we usually do. If there's a need in the community for an operator release before 1.14 is released, we can certainly do so.

Between kiali, grafana, jaeger and prometheus.

This way we can get rid of cluster role bindings.

We create an htpasswd secret unconditionally on the beginning of the control
plane installation, configure all oauth proxies to use that htpasswd
file as another form of authentication and finally configure Kiali
CR to use HTTP basic auth to communicate with those services.
@jwendell jwendell merged commit 9a4bdc8 into maistra:maistra-1.0 Aug 6, 2019
@jwendell
Copy link
Member Author

jwendell commented Aug 6, 2019

Manually merged because mergify is dead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants