-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MAISTRA-624] Use basic HTTP auth for internal communication #173
Conversation
Jaeger Operator PR: jaegertracing/jaeger-operator#573 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@objectiser @jpkrohling Are you going to release a new community image with those changes in? Currently we are installing jaeger operator using the v1.13.1 tag, which points to the image jaegertracing/jaeger-operator:1.13.1. On my tests, using an image generated by @jpkrohling , I was only able to deploy the jaeger operator if using latest CR's from master (instead of using the v1.13.1 GitHub tag). So, I believe that just pushing a new image to docker hub under the same [floating] 1.13.1 tag is not enough. |
We have a |
Between kiali, grafana, jaeger and prometheus. This way we can get rid of cluster role bindings. We create an htpasswd secret unconditionally on the beginning of the control plane installation, configure all oauth proxies to use that htpasswd file as another form of authentication and finally configure Kiali CR to use HTTP basic auth to communicate with those services.
Manually merged because mergify is dead |
Between kiali, grafana, jaeger and prometheus.
This way we can get rid of cluster role bindings.
We create an htpasswd secret unconditionally on the beginning of the control
plane installation, configure all oauth proxies to use that htpasswd
file as another form of authentication and finally configure Kiali
CR to use HTTP basic auth to communicate with those services.