Skip to content

Commit

Permalink
Removed no longer relevant comments from tls_inspector_test
Browse files Browse the repository at this point in the history
  • Loading branch information
dmitri-d committed Mar 12, 2020
1 parent 8ccac21 commit 7f1eb1e
Showing 1 changed file with 0 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,6 @@ TEST_P(TlsInspectorTest, SniRegistered) {
return Api::SysCallSizeResult{ssize_t(client_hello.size()), 0};
}));
EXPECT_CALL(socket_, setRequestedServerName(Eq(servername)));
// Not valid for ALPN "istio" application protocol hack for openssl
EXPECT_CALL(socket_, setRequestedApplicationProtocols(_)).Times(0);
EXPECT_CALL(socket_, setDetectedTransportProtocol(absl::string_view("tls")));
EXPECT_CALL(cb_, continueFilterChain(true));
Expand Down Expand Up @@ -201,7 +200,6 @@ TEST_P(TlsInspectorTest, NoExtensions) {
return Api::SysCallSizeResult{ssize_t(client_hello.size()), 0};
}));
EXPECT_CALL(socket_, setRequestedServerName(_)).Times(0);
// 0 times not valid for ALPN "istio" application protocol hack for openssl
EXPECT_CALL(socket_, setRequestedApplicationProtocols(_)).Times(0);
EXPECT_CALL(socket_, setDetectedTransportProtocol(absl::string_view("tls")));
EXPECT_CALL(cb_, continueFilterChain(true));
Expand Down

0 comments on commit 7f1eb1e

Please sign in to comment.