Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docker): Add linux/arm/v7 architecture to Docker builds #949

Merged
merged 1 commit into from
Jul 8, 2022
Merged

Conversation

mkuf
Copy link
Contributor

@mkuf mkuf commented Jul 8, 2022

This PR adds the linux/arm/v7 architecture to the docker Image Workflow to also support older SBCs.

-Markus

@meteyou meteyou changed the title Add linux/arm/v7 architecture to Docker builds chore(docker): Add linux/arm/v7 architecture to Docker builds Jul 8, 2022
@meteyou meteyou merged commit e5d4e62 into mainsail-crew:develop Jul 8, 2022
@mkuf
Copy link
Contributor Author

mkuf commented Jul 8, 2022

It seems that npm install is failing because Cypress is incompatible with the new architecture and therefore no new images are pushed to the registry.

This can be mitigated by running the build stage only once on a supported platform and then copy the generated web files to the architecture specific runtime images.
This is also how I currently build the mainsail images for prind, see https://github.com/mkuf/prind/blob/main/docker/mainsail/Dockerfile#L2

I'll test this in my fork and then open a new PR.
You might want to revert this PR in the time being.

-Markus

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants