feat: export print history as CSV

[meteyou]

This PR add a function to export selected or all jobs to an CSV file.

fix: #404

Signed-off-by: Stefan Dej [email protected]

[wlhlm]

I see this just joins the strings of each job field with a semi-colon. Does that work safely with filenames that might contain reserved characters?

[pataar]

Note that the delimiter is different in the US and UK. EU: ';', USA/UK: ','

[meteyou]

Does that work safely with filenames that might contain reserved characters?

i think that you would have problems with uploading or printing and that's why you wouldn't even see something like that in the history.

[meteyou]

Note that the delimiter is different in the US and UK. EU: ';', USA/UK: ','

ohhh... thx for this info! because i just use US number format for the export, i think it will be fine to use ',' only.

[wlhlm]

@meteyou

Does that work safely with filenames that might contain reserved characters?

i think that you would have problems with uploading or printing and that's why you wouldn't even see something like that in the history.

I have just tested this and indeed you can't currently print a GCode file with a semicolon in the name because Klipper treats everything following a semi-colon as GCode comment regardless of whether it is quoted or not.

However, the Klipper stack certainly works with commas in filenames as I've been using such a filename scheme for ages and that will result in broken CSV output when using a mainsail language that results in the comma field-separator as you've just implemented.

[meteyou]

@wlhlm thx for testing. i pushed a fix. with the new commit i use the local number format and escape the csv seperator in strings. pls test this again, if this would fit.

[wlhlm]

Thx for the fix! I'm wondering why not pull in a battle-tested CSV generator as a dependency that does proper escaping instead of a home-grown implementation? Just skimming through my mainsail node_modules for example I could find d3-dsv which is an indirect dependency of mainsail. It's a pretty straight-forward module with about 160LOC.

[meteyou]

Because it's easier and faster to generate it this way and I don't want to add new deps for it (the module you linked above, I think it is to parse a CSV file. Reverse direction I need in this case).

[wlhlm]

(the module you linked above, I think it is to parse a CSV file. Reverse direction I need in this case).

Have a look at d3.csvFormat().

[meteyou]

Have a look at d3.csvFormat().

this function do complete the same as i implemented. i have to define the seperator exactly the same way... its more complex to use a lib for this very very small usage. a CSV file is just a text file. if we would export an excel file, i would use a dep.