Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: replace font icons with their svg counterparts #646

Merged
merged 24 commits into from
Mar 2, 2022
Merged

refactor: replace font icons with their svg counterparts #646

merged 24 commits into from
Mar 2, 2022

Conversation

pataar
Copy link
Member

@pataar pataar commented Feb 16, 2022 •
edited
Loading

Replaces the mdi font with mdi svg icons per: https://vuetifyjs.com/en/features/icon-fonts/#material-design-icons-js-svg.

Advantages SVG icons in comparison to font-based icons

  • Easier to chunk
  • Aren't blocking the first time paint
  • Tree shakable

@lixxbox lixxbox added the analyze runs build size report label Feb 16, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Feb 16, 2022 •
edited
Loading

Size Change: -383 kB (-21%) 🎉

Total Size: 1.4 MB

Filename Size Change
./dist/assets/Heightmap.js 121 kB +105 B (0%)
./dist/assets/Heightmap.css 284 B +1 B (0%)
./dist/assets/index.js 251 kB +2.11 kB (+1%)
./dist/assets/index.css 10.1 kB -46.6 kB (-82%) 🏆
./dist/assets/materialdesignicons-webfont.woff2 0 B -354 kB (removed) 🏆
./dist/assets/vendor.js 455 kB +14.9 kB (+3%)
./dist/assets/Viewer.js 282 kB +115 B (0%)
ℹ️ View Unchanged
Filename Size
./dist/assets/Codemirror.css 20 B
./dist/assets/Codemirror.js 113 kB
./dist/assets/vendor.css 64.5 kB
./dist/assets/Viewer.css 318 B
./dist/config.json 25 B
./dist/fonts/roboto-black.woff2 11 kB
./dist/fonts/roboto-bold.woff2 11 kB
./dist/fonts/roboto-light.woff2 11.2 kB
./dist/fonts/roboto-medium.woff2 11.1 kB
./dist/fonts/roboto-regular.woff2 11 kB
./dist/fonts/roboto-thin.woff2 11 kB
./dist/img/icons/apple-touch-icon-152x152.png 4.38 kB
./dist/img/icons/favicon-16x16.png 569 B
./dist/img/icons/favicon-32x32.png 1.05 kB
./dist/img/icons/icon-196-png 3.97 kB
./dist/img/icons/icon-512-png 11.1 kB
./dist/img/icons/mstile-150x150.png 4.26 kB
./dist/img/klipper.svg 3.4 kB
./dist/img/logo.svg 4.08 kB
./dist/img/sidebar-background.svg 1.33 kB
./dist/index.html 692 B
./dist/sw.js 6.26 kB

compressed-size-action

@github-actions github-actions bot removed the analyze runs build size report label Feb 16, 2022
@lixxbox lixxbox added the analyze runs build size report label Feb 16, 2022
@github-actions github-actions bot removed the analyze runs build size report label Feb 16, 2022
@pataar pataar added the analyze runs build size report label Feb 16, 2022
@pataar pataar added analyze runs build size report and removed analyze runs build size report labels Feb 16, 2022
@github-actions github-actions bot removed the analyze runs build size report label Feb 16, 2022
@pataar pataar added the analyze runs build size report label Feb 17, 2022
@pataar pataar added analyze runs build size report and removed analyze runs build size report labels Feb 17, 2022
@github-actions github-actions bot removed the analyze runs build size report label Feb 17, 2022
@pataar pataar marked this pull request as ready for review February 17, 2022 20:44
@pataar pataar marked this pull request as draft February 17, 2022 20:44
@pataar pataar added the analyze runs build size report label Feb 17, 2022
@github-actions github-actions bot removed the analyze runs build size report label Feb 17, 2022
@pataar pataar marked this pull request as ready for review February 19, 2022 21:49
@pataar pataar marked this pull request as draft February 19, 2022 21:50
@pataar
Merge remote-tracking branch 'upstream/develop' into feature/replace_…
dc75e81 
…font_icons_with_svg_icons

# Conflicts:
#	src/pages/Heightmap.vue
@pataar pataar added the analyze runs build size report label Mar 1, 2022
@pataar pataar marked this pull request as ready for review March 1, 2022 19:56
@pataar pataar requested a review from meteyou March 1, 2022 19:59
@meteyou meteyou merged commit 213bffd into mainsail-crew:develop Mar 2, 2022
dw-0 added a commit to dw-0/mainsail that referenced this pull request Mar 3, 2022
@dw-0
fix: missing icon imports (follow up of mainsail-crew#646)
08cef25 
Signed-off-by: Dominik Willner <[email protected]>
dw-0 added a commit that referenced this pull request Mar 3, 2022
@dw-0
fix: missing icon imports (follow up of #646) (#687)
b3a0523
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meteyou meteyou meteyou approved these changes

Assignees
No one assigned
Labels
analyze runs build size report
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pataar @meteyou @lixxbox