Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): partial improvement of config syntax highlighting #612

Merged
merged 51 commits into from
Jul 10, 2022

Conversation

freasy
Copy link
Contributor

@freasy freasy commented Feb 7, 2022

No description provided.

Signed-off-by: Eike Ahmels <[email protected]>
Signed-off-by: Eike Ahmels <[email protected]>
dw-0
dw-0 previously requested changes May 11, 2022
Copy link
Member

@dw-0 dw-0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • failed checks
  • empty functions
  • unused code imports
  • invalid character for comment in gcode defined

@dw-0 dw-0 changed the title fixes the current klipper conf highlighting in the editor fix(editor): partial improvement of config syntax highlighting May 11, 2022
@dw-0 dw-0 added the analyze runs build size report label Jun 29, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 29, 2022

Size Change: +77 B (0%)

Total Size: 2.25 MB

Filename Size Change
./dist/assets/Codemirror.js 122 kB +122 B (0%)
./dist/assets/Codemirror.css 0 B -20 B (removed) 🏆
./dist/assets/index.js 328 kB -9 B (0%)
./dist/sw.js 6.28 kB -16 B (0%)
ℹ️ View Unchanged
Filename Size
./dist/assets/Heightmap.css 282 B
./dist/assets/Heightmap.js 120 kB
./dist/assets/index.css 10.8 kB
./dist/assets/vendor.js 533 kB
./dist/assets/vendor.css 64.5 kB
./dist/assets/Viewer.js 943 kB
./dist/assets/Viewer.css 244 B
./dist/config.json 25 B
./dist/fonts/roboto-black.woff2 11 kB
./dist/fonts/roboto-bold.woff2 11 kB
./dist/fonts/roboto-light.woff2 11.2 kB
./dist/fonts/roboto-medium.woff2 11.1 kB
./dist/fonts/roboto-regular.woff2 11 kB
./dist/fonts/roboto-thin.woff2 11 kB
./dist/img/icons/apple-touch-icon-180x180.png 6.47 kB
./dist/img/icons/favicon-16x16.png 355 B
./dist/img/icons/favicon-32x32.png 641 B
./dist/img/icons/icon-192-png 7.86 kB
./dist/img/icons/icon-512-png 33 kB
./dist/img/icons/mstile-150x150.png 2.24 kB
./dist/img/icons/safari-pinned-tab.svg 1.38 kB
./dist/img/klipper.svg 2.38 kB
./dist/img/logo.svg 295 B
./dist/img/sidebar-background.svg 929 B
./dist/index.html 715 B

compressed-size-action

@dw-0 dw-0 removed the analyze runs build size report label Jun 29, 2022
dw-0 added 5 commits June 29, 2022 18:37
# Conflicts:
#	package-lock.json
#	package.json
#	src/components/inputs/Codemirror.vue
Signed-off-by: Dominik Willner <[email protected]>
Signed-off-by: Dominik Willner <[email protected]>
@dw-0 dw-0 added analyze runs build size report and removed analyze runs build size report labels Jun 29, 2022
@dw-0 dw-0 requested review from dw-0 and meteyou and removed request for dw-0 and meteyou June 29, 2022 16:53
@dw-0 dw-0 dismissed their stale review July 2, 2022 18:09

requested changes were pushed to this PR

@meteyou meteyou merged commit ea8e8e8 into mainsail-crew:develop Jul 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants