fix: add icons for print settings #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As much as I would like to see the rabbit in Mainsail 😜, we discussed this internally and decided it wouldn‘t fit the new „lock slider“ feature added in 2.1beta. Too many icons in the same place. |
|
So then are you removing the icons for the other sliders that already have icons? I agree on a touch device it is cluttered, but on a desktop it looks nice. |
|
This is what they all look like with all the locking sliders.
|
dw-0
pushed a commit
to dw-0/mainsail
that referenced
this pull request
Dec 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding icons for the print settings.